DNS Forward NSG Support for Bloxone Ansible v2 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Dec 2, 2024
unasra
reviewed
Dec 16, 2024
unasra
reviewed
Dec 23, 2024
| - name: Get Forward NSG information by filters (e.g. name) | ||
| infoblox.bloxone.dns_forward_nsg_info: | ||
| filters: | ||
| name: "example_nsg" |
There was a problem hiding this comment.
seems to be fine, please re check
unasra
reviewed
Jan 10, 2025
|
LGTM |
mathewab
approved these changes
Jan 16, 2025
| csp_url: "{{ csp_url }}" | ||
| api_key: "{{ api_key }}" | ||
| block: | ||
| # Create a random Auth Zone name to avoid conflicts |
There was a problem hiding this comment.
Suggested change
| # Create a random Auth Zone name to avoid conflicts | |
| # Create a random Forward Zone name to avoid conflicts |
| RETURN = r""" | ||
| id: | ||
| description: | ||
| - ID of the ForwardNsg object |
There was a problem hiding this comment.
Suggested change
| - ID of the ForwardNsg object | |
| - ID of the Forward NSG object |
| returned: Always | ||
| objects: | ||
| description: | ||
| - ForwardNsg object |
There was a problem hiding this comment.
Suggested change
| - ForwardNsg object | |
| - Forward NSG object |
| module: dns_forward_nsg_info | ||
| short_description: Manage Forward NSG | ||
| description: | ||
| - Manage Forward NSG |
There was a problem hiding this comment.
The description of _info modules should be Retrieve ..., and not Manage. I see this in some other modules too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for forward NSG in v2 ansible
Integration test - pass
Sanity - pass
Lint check - pass